# new issues

8 files changed, +192 −11 in drizzle-team/drizzle-orm. The author left no usable description, so this brief describes structure only.

| | |
| --- | --- |
| Status | MERGED · CHECKS FAILING |
| Source | github:drizzle-team/drizzle-orm#6072 |
| Original | https://github.com/drizzle-team/drizzle-orm/pull/6072 |
| Workspace | Showcase |
| Tags | github, code, typescript, docs |

## What it does

**The change is spread across 8 files in 3 areas, with no single file dominating.**

8 files changed across 3 areas of drizzle-team/drizzle-orm, 192 added and 11 removed.

The author left no description on this change, so nothing below comes from their account of it.

**Diagram: Where the change landed. Node size is not to scale; the line counts are exact.**

- drizzle-orm (8 files, 203 lines) [accent]
- Tests (4 files, 184 lines) [good]
- Source (3 files, 15 lines) [accent]
- Docs (1 file, 4 lines) [neutral]
- pull.test.ts (+89 −0) [neutral]
- drizzle-orm -> Tests
- drizzle-orm -> Source
- drizzle-orm -> Docs
- Tests -> pull.test.ts : heaviest

- **Heaviest file.** drizzle-kit/tests/mssql/pull.test.ts, +89 −0, which is 44% of the change.
- **Tests moved with it.** 4 test files changed alongside 3 source files.
- **CI is red.** 12 checks are failing, so the change is not currently in a mergeable state.

## How it works

**The largest single edit is in pull.test.ts.**

Quoted verbatim from the diff. This is the biggest hunk by changed lines, which is where a reviewer's attention usually belongs first.

**Diagram: Source files matched to test files by filename. A name-based match, so treat it as a prompt to look rather than as proof.**

- NO TEST CHANGED (3)
  - common.ts (+0 −6) [bad]
  - ddl.ts (+3 −2) [bad]
  - pull-common.ts (+2 −2) [bad]
- TEST CHANGED TOO (0)
  - no source file paired [bad]

```typescript
@@ -742,3 +742,92 @@ test('Issue #5964. View with comments', async () => {
 		},
 	]);
 });
+
+// https://github.com/drizzle-team/drizzle-orm/issues/5993
+test('Issue No5993', async () => {
+	await db.query(`CREATE TABLE dbo.duplicate_index_a (
+  id int NOT NULL,
+  value int NULL
+);`);
+	await db.query(
+		`CREATE TABLE dbo.duplicate_index_b (
+  id int NOT NULL,
+  value int NULL
+);`,
+	);
+	await db.query(
+		`CREATE INDEX IX_DUPLICATE_NAME ON dbo.duplicate_index_a(value);`,
+	);
+	await db.query(
+		`CREATE INDEX IX_DUPLICATE_NAME ON dbo.duplicate_index_b(value);`,
```

_drizzle-kit/tests/mssql/pull.test.ts, +89 −0. The largest hunk in the largest file._

## File map

**Every file this change touches, heaviest first.**

Role is inferred from the path and risk from the path and the line count. Neither was read from the code.

| File | Role | Change | Risk |
| --- | --- | --- | --- |
| `drizzle-kit/tests/mssql/pull.test.ts` | test coverage | modified, +89 −0 | low |
| `integration-tests/tests/pg/common-pt2.ts` | test coverage | modified, +61 −0 | low |
| `drizzle-orm/tests/sql-builder.test.ts` | test coverage | modified, +30 −0 | low |
| `drizzle-kit/src/cli/validations/common.ts` | application code | modified, +0 −6 | low |
| `drizzle-kit/src/dialects/mssql/ddl.ts` | application code | modified, +3 −2 | low |
| `changelogs/drizzle-kit/1.0.0-rc.5.md` | documentation | modified, +3 −1 | none |
| `drizzle-kit/src/cli/commands/pull-common.ts` | application code | modified, +2 −2 | low |
| `drizzle-kit/tests/mssql/mocks.ts` | test coverage | modified, +4 −0 | low |

## Receipts

**Where each number above comes from.**

All of it is arithmetic over the file list and the check results, so it can be recomputed from the source.

- **Claim.** Repeated block: 4 occurrences.
  - Evidence: ],
entityType: 'indexes',
isUnique: false,
  - Where: drizzle-kit/tests/mssql/pull.test.ts
- **Claim.** 8 files changed, +192 −11.
  - Evidence: drizzle-kit/tests/mssql/pull.test.ts (+89 −0); integration-tests/tests/pg/common-pt2.ts (+61 −0); drizzle-orm/tests/sql-builder.test.ts (+30 −0)
  - Where: https://github.com/drizzle-team/drizzle-orm/pull/6072
- **Claim.** pull.test.ts carries 44% of the changed lines.
  - Evidence: 89 of 203 changed lines
  - Where: drizzle-kit/tests/mssql/pull.test.ts
- **Claim.** It arrived as 1 commit.
  - Evidence: new issues
  - Where: commit 7c2b476
- **Claim.** CI reports 12 failing of 30.
  - Evidence: run-feature / int:sqlite
  - Where: CI check: run-feature / int:sqlite

## Where to attack

**What the shape of this diff suggests looking at first.**

These come from structure alone: which areas were touched, what was not touched alongside them, and what CI says. None of them is a judgement about the code.

- **run-feature / int:sqlite is failing** (high)
  - No summary was published for this check.
  - Mitigation: Read the check output before anything else here matters.
- **run-feature / int:postgres is failing** (high)
  - No summary was published for this check.
  - Mitigation: Read the check output before anything else here matters.

## Merge order

**A reading order for the review, not a deployment plan.**

Ordered by how expensive each part is to get wrong, which is a structural property rather than an informed one.

1. **Read the failing check first.** run-feature / int:sqlite is red. Everything else is provisional until that is understood.
2. **Then pull.test.ts.** The largest single file in the change, +89 −0.
3. **Finish with the tests.** 4 test files changed. Reading them last tells you what the author believed they were changing.

## What this brief could not check

- No language model read this change. Every statement here is computed from file paths, line counts, and CI status, so it describes the shape of the diff and not what the diff means.